Skip to content

Fix problems caused by case of worksheet names #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2020
Merged

Fix problems caused by case of worksheet names #1065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c13455
Fix problems caused by case of worksheet names
Alanscut Jan 2, 2020
6d0d06a
Fix errors
Alanscut Jan 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/doc/workbook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class Workbook {
console.warn(`Worksheet name ${name} exceeds 31 chars. This will be truncated`);
}
name = (name || `sheet${id}`).substring(0, 31);
if (this._worksheets.find(ws => ws && ws.name === name)) {
if (this._worksheets.find(ws => ws && ws.name.toLowerCase() === name.toLowerCase())) {
throw new Error(`Worksheet name already exists: ${name}`);
}

Expand Down
12 changes: 12 additions & 0 deletions spec/integration/worksheet.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,6 +403,18 @@ describe('Worksheet', () => {
});

context('when worksheet name already exists', () => {
it('throws an error', () => {
const wb = new ExcelJS.Workbook();

const validName = 'thisisaworksheetnameinuppercase';
const invalideName = 'THISISAWORKSHEETNAMEINUPPERCASE';
const expectedError = `Worksheet name already exists: ${invalideName}`;

wb.addWorksheet(validName);

expect(() => wb.addWorksheet(invalideName)).to.throw(expectedError);
});

it('throws an error', () => {
const wb = new ExcelJS.Workbook();

Expand Down