fix issue #1118 Adding Data Validation and Conditional Formatting to the same sheet causes corrupt workbook #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Siemienik merged 1 commit into exceljs:master from Alanscut:issue_1118

Mar 22, 2020

Member

Alanscut commented Feb 18, 2020

Changes:

fix for issue [BUG] Adding Data Validation and Conditional Formatting to the same sheet causes corrupt workbook #1118
conditionalFormattings must be before dataValidations


          fix issue exceljs#1118

752843c

dogusev approved these changes

View reviewed changes

Contributor

dogusev left a comment

I this fixes this issue

Waiting to this PR be merged!

Contributor

dogusev commented Mar 21, 2020

@Alanscut Any chances to have it published?

Member Author

Alanscut commented Mar 22, 2020

@dogusev It's up to @guyonroche , @Siemienik , @alubbe :)

Siemienik approved these changes

View reviewed changes

Siemienik merged commit 9e2467b into exceljs:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet