Optimize SAXStream #1140
Merged
Optimize SAXStream #1140
+339
−334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we try to review/merge this PR? If anything here is unclear, is there anything I can improve? |
|
@alubbe I'm going to review when I will have some time |
Siemienik
approved these changes
Mar 28, 2020
There was a problem hiding this comment.
Generally, it looks ok :) I have only one quite simple note here.
Let's take me a minute before merging to test it with my lib xlsx-renderer. There it has some testes which should additionally check if reader and writer work 100% correctly.
| super(); | ||
| this.sax = new saxes.SaxesParser(); | ||
| module.exports = class SAXStream extends Stream.Transform { | ||
| constructor(eventTypes) { |
There was a problem hiding this comment.
I see that eventTypes everywhere has the same value, as sax-stream.js is an internal utility I think you should use default value here.
There was a problem hiding this comment.
Good catch - fixed in #1135
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings over improvements and speed-ups from #1135 that work on nodejs v8. It will help make the diff of the other PR smaller