-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Deprecate createInputStream #1209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am writing upgrade instruction, it will be added soon.
@alubbe @Siemienik Awesome work you guys have put in here! It's time to publish again - this PR making for major version. Is there anything else you think should go in first? |
@alubbe @Siemienik just a couple of questions... I noticed somewhere along the line about 22 days ago that the .travis.yml file got dropped - was this intentional? |
This PR itself is not backwards incompatible, it just adds warnings, so this can still be released as v3. We've dropped travis to use github actions instead, and we've greatly increased the amount of things we test and platforms we test on (see https://github.com/exceljs/exceljs/pull/1190/files) |
We planned to publish it in v3,
I added github workflow for checking if index.d.ts is compiled correctly: But it has side-effect - it's turn off Travis checks So @alubbe made this PR with migration from travis to github workflows: #1190 |
@guyonroche @alubbe @Siemienik I have to say your work is great, but I found that there are still some problems with index.d.ts.
This is the pain point of |
I'm not a TS user myself, so I have no idea about any of this - but personally, I think we've never guaranteed that |
Well, I will be a big fan of migrating to TS (with --allowJs) and step by step move our logic form js files to ts 😄 I feel a big lack of types, now I have to investigate the whole project to do something because IDE doesn't provide intellisense😭. I wonder about create milestones, fo version 4.1, 4.2 and 5. It should help us to keep one vision of further developing this library. What is your opinion? |
I'd also like us to move to Typescript, but |
As discussed in #1135, let's deprecate
createInputStream
in favour of theread
methods in 4.0