Skip to content

Added insert rows functionality with new style inherit options #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jun 14, 2020
Merged

Added insert rows functionality with new style inherit options #1324

merged 21 commits into from
Jun 14, 2020
+367 −22

Conversation

Subhajitdas298
Copy link
Contributor

@Subhajitdas298 Subhajitdas298 commented Jun 10, 2020 •
edited
Loading

Replacement of #1291

Summary

Added new methods, for inserting row/s. Also added styleOption to allow style inherit.

Test plan

Added unit tests accordingly.

Subhajitdas298 and others added 21 commits May 22, 2020 22:53
@Subhajitdas298
Fixed error message of bable for file above 500KB
77896c7
@Subhajitdas298
Added insert row/s
4a1d84a
@Subhajitdas298
Added insertRow test cases
eb954c9
@Subhajitdas298
Merge pull request #2 from exceljs/master
d82acc3 
Merge pull request exceljs#1289 from Subhajitdas298/master
@Subhajitdas298
Added readme info
0d46004
@Subhajitdas298
Merge branch 'master' of https://github.com/Subhajitdas298/exceljs
d87109f
@Subhajitdas298
Fixed insert row(s) instructions
2f9e742
@Subhajitdas298
Merge branch 'master' into master
e46ae8c
@Subhajitdas298
Merge pull request #3 from exceljs/master
6fe8497 
Fetch update
@Subhajitdas298
Added styleOption to add row/s and insert row/s
90e6498
@Subhajitdas298
Merge branch 'master'
6456bce
@Subhajitdas298
Changed babel compact to false
98b4399
@Subhajitdas298
Added jump in insert rows
f1d02b0
@Subhajitdas298
Merge pull request #4 from exceljs/master
5247eb1 
Merge latest repo
@Subhajitdas298
Object.freeze for style
7a32223
@Subhajitdas298
Merge branch 'master' of https://github.com/Subhajitdas298/exceljs
6b52849
@Subhajitdas298
Merge
3c76a7a
@Subhajitdas298
Rebase for chinese readme
8c1d6de
@Subhajitdas298
Merge pull request #7 from exceljs/master
a5e4c80 
M2
@Subhajitdas298
Added chinese readme data
154829f
@Subhajitdas298
Merge branch 'master' of https://github.com/Subhajitdas298/exceljs
f5c5d25
@Subhajitdas298
Copy link
Contributor Author

@alubbe @Siemienik This pull request is created as I was having weird issue, merging with earlier code. Please review this request.
@Siemienik The property setter is exposed and does not use Object.freeze yet. This can be added in another PR.
For this PR, only internal copying is happening, like spliceRows. Though, I have added the modification you have asked. Please review. Thanks.

Siemienik
Siemienik approved these changes Jun 13, 2020
View reviewed changes
Copy link
Member

@Siemienik Siemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good form me, I see also that is well tested code. 👍

@alubbe alubbe merged commit 72f8f90 into exceljs:master Jun 14, 2020
Subhajitdas298 added a commit to Subhajitdas298/exceljs that referenced this pull request Jun 14, 2020
@Subhajitdas298
Merge pull request #8 from exceljs/master
32da8d1 
Merge pull request exceljs#1324 from Subhajitdas298/master
@Alek-S Alek-S mentioned this pull request Jun 22, 2020
Closed
@cduff cduff mentioned this pull request Jun 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siemienik Siemienik Siemienik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Subhajitdas298 @Siemienik @alubbe