bug fix can not read property date1904 of undefined #1328
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue:
ExcelJs.stream.xlsx.WorkbookReader reading with styles: cache option was giving
Cannot read property 'date1904' of undefined
Reproduce with this code
Above code will throw an error when
DD/MM/YYYY
format date is given in the excele.g: 20/06/2020
I found that in
lib/stream/xlsx/worksheet-reader.js
we are using it but not checking for the undefined model case.