Skip to content

[bugfix]Fix Issue #1254 and update index.d.ts #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 28, 2020
Merged

[bugfix]Fix Issue #1254 and update index.d.ts #1360

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b00586d
Fix issue #1254 and update index.d.ts
Alanscut Jun 30, 2020
d77bd43
Merge branch 'master' of https://github.com/exceljs/exceljs into issu…
Alanscut Jun 30, 2020
eac22fa
update index.d.ts
Alanscut Jul 1, 2020
b8e3df7
Merge branch 'master' of https://github.com/exceljs/exceljs into issu…
Alanscut Jul 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ export declare enum FormulaType {
}

export type CellValue =
| null | number | string | boolean | Date
| null | number | string | boolean | Date | undefined
| CellErrorValue
| CellRichTextValue | CellHyperlinkValue
| CellFormulaValue | CellSharedFormulaValue;
Expand Down Expand Up @@ -1075,6 +1075,9 @@ export interface DataBarRuleType extends ConditionalFormattingBaseRule {
export type ConditionalFormattingRule = ExpressionRuleType | CellIsRuleType | Top10RuleType | AboveAverageRuleType | ColorScaleRuleType | IconSetRuleType
| ContainsTextRuleType | TimePeriodRuleType | DataBarRuleType;


export type RowValues = CellValue[] | { [key: string]: CellValue } | undefined | null;

export interface ConditionalFormattingOptions {
ref: string;
rules: ConditionalFormattingRule[];
Expand Down Expand Up @@ -1234,7 +1237,7 @@ export interface Worksheet {
/**
* return all rows as sparse array
*/
getSheetValues(): Row[];
getSheetValues(): RowValues[];

/**
* returns the cell at [r,c] or address given by r. If not found, return undefined
Expand Down