Skip to content

Clarify encoding option is just for .writeFile #1496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

ArtskydJ
Copy link
Contributor

@ArtskydJ ArtskydJ commented Oct 9, 2020

This is a docs improvement. It notes that the encoding option is for workbook.csv.writeFile, and not workbook.csv.write.

Summary

The motivation is that the encoding option wasn't fully clear which methods it applied to. See also #1473.

Test plan

N/A

Other

This change is extremely minor... I can add it to #1495 if wanted, since they're both related to this encoding option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants