Fixed conditional format corrupting sheet #1305 #1574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm that this fixes the issue with conditional styling and the corruption of the worksheet |
Siemienik
approved these changes
Apr 11, 2021
There was a problem hiding this comment.
I confirm that the new order is correct:
https://github.com/exceljs/ooxml-xsd/blob/aba7f40dc52d9a3cfe236e9e3e15a5148d5ca999/sml-styles.xsd#L830-L868
Thank you for that great contribution! 🥇 LGTM.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'm using a template for styling, and filling out data with ExcelJS. When my template had conditional formatting enabled on it, opening it and writing the file (even without data being inserted) would corrupt the file and lose styling. While investigating the issue I ran into this comment I tried it and it worked, and since I wasn't able to find a PR mentioning this fix I decided to open one myself.
Test plan
My original template file's conditional formatting:
After being loaded by ExcelJS and rewritten into a different file:
Notes
I understand the README.md mentioned writing tests for all fixes but I'm not really familiar with it, I can write them if someone could point me in the right direction.