Skip to content

fix #1598 lint violations #1599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 14, 2021
Merged

fix #1598 lint violations #1599

merged 5 commits into from
Feb 14, 2021
+43 −46

Conversation

iva2k
Copy link
Contributor

@iva2k iva2k commented Jan 28, 2021

Summary

fixes #1598

Test plan

npm run lint
npm run test

All PASS

@iva2k
Copy link
Contributor Author

iva2k commented Jan 28, 2021

argh!
git commit hook prettifies the code, removes all parenthesis that were added to fix lint violations "no-mixed-operators Unexpected mix of '+' and '*' ", and fixes end up not going in. I'll update this PR when I find and fix pretty setting that does that.

@iva2k
Copy link
Contributor Author

iva2k commented Jan 28, 2021

I committed fixes for "no-mixed-operators" violations. It's ready for merge.

@Siemienik Siemienik self-requested a review February 12, 2021 02:29
Siemienik
Siemienik approved these changes Feb 14, 2021
View reviewed changes
Copy link
Member

@Siemienik Siemienik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you 🥇

@Siemienik Siemienik merged commit 18fde32 into exceljs:master Feb 14, 2021
@dependabot dependabot bot mentioned this pull request Mar 12, 2021
Merged
@Siemienik Siemienik mentioned this pull request Apr 11, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siemienik Siemienik Siemienik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] npm run lint reports multiple violations
2 participants
@iva2k @Siemienik