Skip to content

Fix fullAddress row and col types #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2021
Merged

Fix fullAddress row and col types #1606

merged 1 commit into from
Feb 14, 2021

Conversation

Akxe
Copy link
Contributor

@Akxe Akxe commented Feb 2, 2021

Summary

I want to fix types

Col:

exceljs/lib/doc/anchor.js

Lines 40 to 42 in e1de626

get col() {
return this.nativeCol + Math.min(this.colWidth - 1, this.nativeColOff) / this.colWidth;
}

Row:

exceljs/lib/doc/anchor.js

Lines 49 to 51 in e1de626

get row() {
return this.nativeRow + Math.min(this.rowHeight - 1, this.nativeRowOff) / this.rowHeight;
}

Test plan

No test found for types in this library

@Siemienik Siemienik self-requested a review February 12, 2021 02:29
Siemienik
Siemienik approved these changes Feb 14, 2021
View reviewed changes
Copy link
Member

@Siemienik Siemienik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 very thanks

I'm contributing ExcelJS just for fun. If want you to know something more go into #1500

@Siemienik Siemienik merged commit 4a65a32 into exceljs:master Feb 14, 2021
@Akxe Akxe deleted the patch-1 branch February 14, 2021 23:16
@dependabot dependabot bot mentioned this pull request Mar 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siemienik Siemienik Siemienik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Akxe @Siemienik