Skip to content

doc: add example for solid pattern usage #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2021
Merged

Conversation

fpaupier
Copy link
Contributor

@fpaupier fpaupier commented Mar 30, 2021

Summary

Current doc for cell filling could lead to misunderstanding on how to apply a simple fill color
to a cell.

Related to #1658 (#272)

Test plan

No test required for a readme update.

Current doc for cell filling could lead to misunderstanding on how to apply a simple fill color
to a cell.

Related to exceljs#272
@fpaupier fpaupier mentioned this pull request Mar 30, 2021
Copy link
Member

@Siemienik Siemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you! 📖 👍

@Siemienik Siemienik merged commit ae2d2e5 into exceljs:master Apr 11, 2021
@exceljs exceljs locked as resolved and limited conversation to collaborators Apr 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants