Skip to content

Fix issue #1753 Reject promise when workbook reader is writing to temporary file stream and error occurs #1756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 14, 2023
Merged

Fix issue #1753 Reject promise when workbook reader is writing to temporary file stream and error occurs #1756

merged 4 commits into from
Apr 14, 2023

Conversation

pauliusg
Copy link
Contributor

Summary

Fixes issue #1753

Workbook code which is creating temporary file by using write stream is not watching for error event, so in case of error promise was not resolved and code stays in hanging state.

Fix issue exceljs#1753 Reject promise when workbook reader is writing…
798347c 
… to temporary file stream and error occurs
@Siemienik Siemienik self-requested a review November 18, 2021 00:35
@Siemienik Siemienik self-assigned this Apr 6, 2023
@pauliusg
Copy link
Contributor Author

Why this one is still not merged?

@Siemienik
Copy link
Member

Hello hello @pauliusg , for quite a long time none of the maintainers had enough time to properly take care of this project. Especially since it is being created voluntarily in their free time. Thank you very much for your contribution, and I will try to merge this PR as soon as possible.
By the way, yesterday we did our first "MergeFest" and there were 3 of us on the online stream. Today we plan to merge more PRs. It would be great if you could join us, you could guide us through this PR and the review would be much easier :)
Link to the event on DISCORD, on time: 3PM CEST
I also invite you to join the community on our server https://discord.gg/SNEtBKPUxE

Have a nice day! :)

@pauliusg
Copy link
Contributor Author

pauliusg commented Apr 14, 2023 •
edited
Loading

@Siemienik thanks for response. It is good to know that project is still alive! Unfortunately I can't join you, but this PR is very simple one-liner to properly handle stream errors. More context is in issue: #1753

Siemienik
Siemienik approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@Siemienik Siemienik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really appreciate your contribution, thank you :)

@Siemienik Siemienik merged commit 4acab1d into exceljs:master Apr 14, 2023
coder-xiaotian
coder-xiaotian reviewed Apr 14, 2023
View reviewed changes
Copy link

@coder-xiaotian coder-xiaotian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@j-mendez j-mendez mentioned this pull request Sep 8, 2024
Open
@Vishwas1 Vishwas1 mentioned this pull request Sep 8, 2024
Open
@j-mendez j-mendez mentioned this pull request Sep 13, 2024
Open
This was referenced Sep 15, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coder-xiaotian coder-xiaotian coder-xiaotian left review comments

@Siemienik Siemienik Siemienik approved these changes

@naorpeled naorpeled naorpeled approved these changes

Assignees

@Siemienik Siemienik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pauliusg @Siemienik @naorpeled @coder-xiaotian