Skip to content

Upgrade jszip to its latest version to date. This version does not have any vulnerability found by Snyk so far #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ValerioSevilla
Copy link
Contributor

Snyk found a Denial of Service vulnerability in jszip: https://security.snyk.io/vuln/SNYK-JS-JSZIP-1251497

There is no version of exceljs so far upgrading to a safe version of jszip. This pull request is meant to solve that.

Test plan

Run npm install and npm test after upgrading. All tests passed.

Copy link
Member

@Siemienik Siemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ValerioSevilla, Thank you for that contribution. LGTM 🥇

@Siemienik Siemienik merged commit 0f6d765 into exceljs:master Nov 7, 2021
@ValerioSevilla
Copy link
Contributor Author

@Siemienik thanks! Is there a release planned, or is it possible to quickly get a patch including this upgrade?

@ValerioSevilla ValerioSevilla deleted the feature/upgrade-jszip-to-prevent-security-vulnerability branch November 8, 2021 11:25
@Siemienik
Copy link
Member

Only @guyonroche has permission to release.

@Siemienik
Copy link
Member

@ValerioSevilla see #2351 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants