fix: fix the loss of column attributes due to incorrect column order #2222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanvirstreame
approved these changes
Apr 27, 2023
|
You have 1 unnecessary commit, Please rebase this branch |
I have already processed it, please check again |
Siemienik
approved these changes
May 5, 2023
There was a problem hiding this comment.
🥇 Looks good to me, Thank you for the contribution!
This PR was reviewed during the MergeFest session.
dd0294a to
0680219
Compare
@tanvirstreame |
|
I'm very sorry, I found that the username I submitted does not match the information I registered on GitHub. Can you use the following code to reset my submission information：#!/bin/sh
git filter-branch --env-filter '
***@***.***"
CORRECT_NAME="cpaiyueyue"
***@***.***"
if [ "$GIT_COMMITTER_EMAIL" = "$OLD_EMAIL" ]
then
export GIT_COMMITTER_NAME="$CORRECT_NAME"
export GIT_COMMITTER_EMAIL="$CORRECT_EMAIL"
fi
if [ "$GIT_AUTHOR_EMAIL" = "$OLD_EMAIL" ]
then
export GIT_AUTHOR_NAME="$CORRECT_NAME"
export GIT_AUTHOR_EMAIL="$CORRECT_EMAIL"
fi
' --tag-name-filter cat -- --branches --tags
恋海蓝
***@***.***
…------------------ 原始邮件 ------------------
发件人: "Siemienik ***@***.***>;
发送时间: 2023年5月5日(星期五) 晚上9:09
收件人: ***@***.***>;
抄送: ***@***.***>; ***@***.***>;
主题: Re: [exceljs/exceljs] fix: fix the loss of column attributes due to incorrect column order (PR #2222)
You have 1 unnecessary commit, Please rebase this branch
@tanvirstreame
Sorry, but the additional commit is required to make me able to merge - the branch has to be up-to-date, and during MergeFest I usually merge some PRs, each updates the master making others PRs outdated.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This was referenced Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I try to read the excel file and display it on the page, I found that the hidden columns of some files were not parsed correctly.
Summary
I found that if the order of the column data parsed here is not positive, the subsequent attributes will be overwritten
Test plan
Before modification
After modification