Fix types for getWorksheet() #2223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siemienik
reviewed
Apr 6, 2023
Siemienik
approved these changes
Apr 6, 2023
There was a problem hiding this comment.
Hello, hello @hfhchan-plb . It looks good to me. Thanks:tada:.
Additionally, I spot and update the param indexOrName to optional. Following the source code, if indexOrName is undefined, the function returns the first worksheet.
This was referenced Apr 6, 2023
|
Tests on node v8 failed. I will fix them before the final merge: |
naorpeled
approved these changes
Apr 13, 2023
This was referenced Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix types for getWorksheet(). It can return undefined
Test plan
N/A
Related to source code (for typings update)
lib/doc/workbook.js#L143