Update xlsx.js to allow compat with non office generated files. #2846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some xlsx files generated by 3rd party applications do not come with valid property data in the document formatting. The changes to xlsx.js in this patch seek to allow compatibility with these out of spec files while informing the user of the invalid data. A simple 'fix' to a problem that shouldn't exist but for some reason 3rd party applications prefer to discard design specifications.
|
Adding: my laptop runs node 18.20.4 on Ubuntu 24.04 on kernel 6.1.0-1034-oem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some xlsx files generated by 3rd party applications do not come with valid property data in the document formatting. The changes to xlsx.js in this patch seek to allow compatibility with these out of spec files while informing the user of the invalid data.
A simple 'fix' to a problem that shouldn't exist but for some reason 3rd party applications prefer to discard design specifications.
Test plan
I tested this on one machine running Ubuntu 24.04. I would love to test it more but I have one laptop. I did test against files from 3 3rd party clients (fortiEDR collector export, apache openoffice calc, and libreoffice calc) and 1 file made in excel.