Skip to content

Fix: Changed error-prone race conditions #2874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

StevenGee3398
Copy link

Summary

When dealing with import/export streams, different errors occured under certain circumstances. For example sharedStrings could sometimes not be resolved after editing the exported .xlsx file with excel, even though the inputOptions are set appropiately. More over there were also cases where the sheetnames could not be read after an export, due to the race conditions in the old iterate-stream method. The workbook was not properly initialized in time. There are surely more edge cases in which the current iterate-stream implementation would lead to unexpected behavior.

Unfortunately, I cannot offer sample files since it is somewhat flaky to reproduce and my own data include client information.

The new implementation utilizes Nodes built-in .once method and removes the race conditions that lead to the problems above.

Test plan

None.

Related to source code (for typings update)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant