Fix: Changed error-prone race conditions #2874
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When dealing with import/export streams, different errors occured under certain circumstances. For example sharedStrings could sometimes not be resolved after editing the exported .xlsx file with excel, even though the inputOptions are set appropiately. More over there were also cases where the sheetnames could not be read after an export, due to the race conditions in the old iterate-stream method. The workbook was not properly initialized in time. There are surely more edge cases in which the current iterate-stream implementation would lead to unexpected behavior.
Unfortunately, I cannot offer sample files since it is somewhat flaky to reproduce and my own data include client information.
The new implementation utilizes Nodes built-in .once method and removes the race conditions that lead to the problems above.
Test plan
None.
Related to source code (for typings update)