Add correct parsing for inline strings #495
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inline strings that previously met the XML spec, caused the parsing of the files to fail.
|
@guyonroche I couldn't find the correct place to add tests around parsing of a file. If you can point me in the correct direction I am happy to add them |
|
@robscotts4rb sorry it's taken me so long to get to this. Would this mean we should be writing inline strings as Or do you think that might cause more problems than it solves? |
|
@guyonroche I tried to something similar in #501 and added a very basic unit test in there -- hope it makes sense! |
|
@robscotts4rb thanks for the contribution - I'm going to merge #501 and close this one as they are both working to the same end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline strings that previously met the XML spec, caused the parsing of the files to fail.