Skip to content

update deps for nodejs 10+ #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 6, 2019
Merged

update deps for nodejs 10+ #672

merged 10 commits into from
May 6, 2019

Conversation

async0x42
Copy link

update all deps

@async0x42 async0x42 changed the title Dep update2 update deps for nodejs 10+] Oct 24, 2018
@async0x42 async0x42 changed the title update deps for nodejs 10+] update deps for nodejs 10+ Oct 24, 2018
Copy link
Member

@Siemienik Siemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package-lock seems to be redundant

@async0x42
Copy link
Author

async0x42 commented Jan 17, 2019

package-lock seems to be redundant

Recently I've seen it become more common to ensure the deps exactly match w/ a successful build. If it's not required for this then that's fine.

@Siemienik
Copy link
Member

@async0x42 I prefer keep libraries up to date, because when some deps becomes making troubles, it is two possible ways to choose:

  1. froze last properly worked version
  2. update our code to be up to date

@Siemienik
Copy link
Member

@async0x42 Thank you for PL ;)

@async0x42
Copy link
Author

@async0x42 I prefer keep libraries up to date, because when some deps becomes making troubles, it is two possible ways to choose:

  1. froze last properly worked version
  2. update our code to be up to date

It's what I do for my private repos; works for me!

@Siemienik
Copy link
Member

Siemienik commented Jan 17, 2019

@async0x42 have You any idea how fix travis check for node v6?

@async0x42
Copy link
Author

@async0x42 have You any idea how fix travis check for node v6?

Off-hand, I don't to be honest, and I won't have time to dig into it for a little while. Node v6 will be EOL itself in ~2 months (April 2019), would it be OK to just drop support for that a little early?

Ref: https://github.com/nodejs/Release

@alubbe
Copy link
Member

alubbe commented Apr 3, 2019

Should we merge this on 1st of May, when node 6 is no longer supported? :)

@Siemienik
Copy link
Member

Siemienik commented May 3, 2019

@alubbe @guyonroche , so, v6 is EOL, we should update our Travis.

unfortunately, we do not test v11 and v12, should we?

@Siemienik
Copy link
Member

#803

package.json Outdated
"tmp": "^0.1.0"
"promish": "^5.1.1",
"sax": "^1.2.4",
"temp": "0.8.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still want tmp over temp, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right,
is it now correct?

@alubbe alubbe merged commit 2415152 into exceljs:master May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants