-
Notifications
You must be signed in to change notification settings - Fork 1.9k
update deps for nodejs 10+ #672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package-lock seems to be redundant
Recently I've seen it become more common to ensure the deps exactly match w/ a successful build. If it's not required for this then that's fine. |
@async0x42 I prefer keep libraries up to date, because when some deps becomes making troubles, it is two possible ways to choose:
|
@async0x42 Thank you for PL ;) |
It's what I do for my private repos; works for me! |
@async0x42 have You any idea how fix travis check for node v6? |
Off-hand, I don't to be honest, and I won't have time to dig into it for a little while. Node v6 will be EOL itself in ~2 months (April 2019), would it be OK to just drop support for that a little early? |
Should we merge this on 1st of May, when node 6 is no longer supported? :) |
@alubbe @guyonroche , so, v6 is EOL, we should update our Travis. unfortunately, we do not test v11 and v12, should we? |
package.json
Outdated
"tmp": "^0.1.0" | ||
"promish": "^5.1.1", | ||
"sax": "^1.2.4", | ||
"temp": "0.8.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still want tmp over temp, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right,
is it now correct?
update all deps