Avoid unhandled rejection on XML parse error #813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…error Prevents a parse error from causing an unhandled rejection
|
There seems to something wrong with your prettier configuration, did you run |
|
The |
|
@alubbe regarding the prettier - I changed the config to be lint only - without the fixing as I ended up with a situation where the fixer was outputting code that the linter rejected. In a way - I tend to prefer fixing the lint issues manually it gives the chance to fix the code in a better way than the lint fixer can |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into some maliciously crafted .xlsx files that contained invalid XML, which triggered an unhandled rejection because the stream no longer had an error handler at that point. Seems like I introduced this bug myself back in #541, so it's only fair that I fix it.
The test case is a little out there, but I couldn't find another way to test for an unhandled rejection. The
workbook.xlsx.readFilepromise already got rejected as it was supposed to.