Always keep first font #854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@guyonroche Hi! |
This was referenced Jun 10, 2019
guyonroche
requested changes
Jun 11, 2019
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "exceljs", | |||
| "version": "1.12.1", | |||
| "version": "1.12.2", | |||
There was a problem hiding this comment.
Please don't edit this - it is managed during the release/publish process
| horizontal: 'left', | ||
| vertical: 'middle', | ||
| }, | ||
| expect(ws.getRow(3).style.alignment).to.deep.equal({ |
There was a problem hiding this comment.
Could you add a test that covers your change?
There was a problem hiding this comment.
it took o lot of time to find the issue, not sure i'll be able cover with tests coming days
guyonroche
approved these changes
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Font skipped each time, when
styleId===0related issues
#849
#833
#816