Skip to content

Cleaning up three of the intro Java exercises. #1797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Cleaning up three of the intro Java exercises. #1797

merged 1 commit into from
Apr 14, 2020

Conversation

Valkryst
Copy link
Contributor

@Valkryst Valkryst commented Mar 3, 2020

  • Add access modifiers to Gigasecond.java
  • Add access modifiers to Hamming.java
  • Add access modifiers to Twofer.java
  • Remove unnecessary blank lines from Gigasecond.java
  • Remove unnecessary blank line from Hamming.java

Reviewer Resources:

Track Policies

* Add access modifiers to Hamming.java
* Add access modifiers to Twofer.java
* Remove unnecessary blank lines from Gigasecond.java
* Remove unnecessary blank line from Hamming.java
@jmrunkle
Copy link
Contributor

All of these changes seem good to me, but I think there is a current issue with the Travis CI: #1799. Once we fix that, we should be able to merge this PR.

@jmrunkle jmrunkle self-assigned this Apr 12, 2020
@jmrunkle jmrunkle closed this Apr 14, 2020
@jmrunkle jmrunkle reopened this Apr 14, 2020
@jmrunkle
Copy link
Contributor

Now that we have fixed the test, it looks like closing and reopening is the fastest way to re-trigger the CI test. Shrug.

@jmrunkle jmrunkle merged commit 1a4dcab into exercism:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants