Convert practice exercises starting with 'a' to use AssertJ #2046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmrunkle
reviewed
Oct 12, 2021
There was a problem hiding this comment.
This is definitely an improvement, but I have some comments. Mostly I want the assertions to read as much like English as possible:
assertThat(someOperation)...(someResult)
This means we have to inline some of the bad setups that are just assertThat(result).isEqualTo(expected).
exercises/practice/accumulate/src/test/java/AccumulateTest.java
Outdated
Show resolved
Hide resolved
exercises/practice/accumulate/src/test/java/AccumulateTest.java
Outdated
Show resolved
Hide resolved
exercises/practice/accumulate/src/test/java/AccumulateTest.java
Outdated
Show resolved
Hide resolved
exercises/practice/all-your-base/src/test/java/BaseConverterTest.java
Outdated
Show resolved
Hide resolved
exercises/practice/alphametics/src/test/java/AlphameticsTest.java
Outdated
Show resolved
Hide resolved
- accumulate - acronym - affine-cipher - all-your-base - allergies - alphametics - anagraph - armstrong-numbers - atbash-cipher
- Prefer list and map-specific assertions over generic equality - Prefer inlined variables to separate simple setup - Prefer .containsExactly & friends to .containsExactlyElementsOf & co
|
@jmrunkle appreciate the feedback -- I went ahead and made those adjustments. |
jmrunkle
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull request
Updates the following exercises:
to use AssertJ for the following assertion patterns
assertEquals(x, y)-->assertThat(y).isEqualTo(x)assertTrue(x)-->assertThat(x).isTrue()assertEquals(collectionA, collectionB)-->assertThat(collectionB).containsExactly[ElementsOf](collectionA)I wanted to get feedback on these changes, as I'd seen some other PRs moving towards increased use of AssertJ, and inferred that that was the general direction. In my experience/opinion, AssertJ also gives clearer auto-generated failure messages for the above cases. But please let me know if I'm mistaken/this isn't the direction things are going in, as well as if there are any other tweaks to these patterns before I try making these changes more generally.
Reviewer Resources:
Track Policies