This repository was archived by the owner on Apr 16, 2022. It is now read-only.
Support for "php-attributes" code blocks #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @derrabus. |
|
@derrabus would you mind create a PR at https://github.com/OskarStark/doctor-rst, too? |
|
@OskarStark That GitHub action of yours will probably hit me when I submit my PR, won't it? I'll try to patch it then. 😃 |
|
@OskarStark The action has not failed on symfony/symfony-docs#14230. Should it have? |
|
Hmm strange, will check it on Monday. Feel free to ping me via Slack if I forget 😄 |
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
Oct 14, 2020
This PR was merged into the 5.x branch. Discussion ---------- Use updated dependencies Currently I fail to build the docs in 5.x. They complain on php-attributes. This PR make sure to use @derrabus PR fabpot/sphinx-php#49 released in 2.0.2. This change was missing from #14230 Commits ------- 3c0372a Use updated dependencies
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For my work on symfony/symfony-docs#14188, I need a way to express configuration samples with PHP attributes.
For instance, I'd like to add a tab "Attributes" to the code blocks on this page: https://symfony.com/doc/current/routing.html#matching-http-methods. The change proposed with this PR enables me to do that.