This repository has been archived by the owner on Mar 3, 2020. It is now read-only.
Replace all usage of OSSpinLock with pthread_mutex. #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // lock | ||
| OSSpinLockLock(&_lock); | ||
|
|
||
| pthread_mutex_unlock(&_lock); |
|
Horribly, horribly broken. Please use |
7455bb3 to
fb284c1
Compare
| // unregister info | ||
| OSSpinLockLock(&_lock); | ||
| pthread_mutex_unlock(&_mutex); |
fb284c1 to
4f5c329
Compare
Current coverage is 67.93%@@ master #109 diff @@
========================================
Files 3 3
Lines 235 237 +2
Methods 0 48 +48
Branches 0 45 +45
========================================
- Hits 193 161 -32
- Misses 42 43 +1
- Partials 0 33 +33
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates Podfile and lints a bunch of whitespace.
Fixes #108.