Skip to content

DRY up the subscribe conditional a bit #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2015
Merged

DRY up the subscribe conditional a bit #85

merged 2 commits into from
May 9, 2015

Conversation

JDegner0129
Copy link
Contributor

'nuff said

@inoryy
Copy link

inoryy commented May 9, 2015

Might as well replace whole function body with

def subscribe(self, msg, subscriber):
    self.subscribers.setdefault(msg, []).append(subscriber)

@JDegner0129
Copy link
Contributor Author

You got it. JDegner0129@bbc1749

faif added a commit that referenced this pull request May 9, 2015
@faif
Merge pull request #85 from JDegner0129/fix-pubsub-conditional
cf4b435 
DRY up the subscribe conditional a bit
@faif faif merged commit cf4b435 into faif:master May 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JDegner0129 @inoryy @faif