Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Binary constraint #1510

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

emma-carballal
Copy link
Contributor

@emma-carballal emma-carballal commented Feb 19, 2025

Fixes #1476

Description

This PR adds a binary constraint on y in the Parameters of the ThresholdOptimizer docstring.

Tests

  • no new tests required
  • new tests added
  • existing tests adjusted

Documentation

  • no documentation changes needed
  • user guide added or updated
  • API docs added or updated
  • example notebook added or updated

@emma-carballal
Copy link
Contributor Author

As part of the PyLadies contribution sprint.
@TamaraAtanasoska
@taharallouche

Copy link
Member

@taharallouche taharallouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @emma-carballal 🙏

@emma-carballal
Copy link
Contributor Author

I've now managed to get rid of the extra commits that didn't belong to this PR.

@taharallouche taharallouche merged commit 6848280 into fairlearn:main Feb 20, 2025
34 checks passed
@emma-carballal emma-carballal deleted the binary-constraint branch February 20, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Documentation for Binary Constraint on y Argument in ThresholdOptimizer's .fit Method
2 participants