Skip to content

Introduce LongBinaryPacking #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 28, 2024
Merged

Conversation

blacelle
Copy link
Collaborator

No description provided.

@blacelle
Copy link
Collaborator Author

@lemire This is ready for review

@lgtm-com
Copy link

lgtm-com bot commented Nov 28, 2022

This pull request introduces 16 alerts when merging 5b86fe7 into 1e48bd0 - view on LGTM.com

new alerts:

  • 16 for Implicit narrowing conversion in compound assignment

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@ethlo
Copy link

ethlo commented Feb 28, 2024

Hi! This looks like what I need for my project. Is there a chance that this can be merged (and hopefully released on Maven central? Is there anything I can contribute to make this happen? Thank you for your time.

@blacelle
Copy link
Collaborator Author

I resynced the PR

@lemire
Copy link
Member

lemire commented Feb 28, 2024

Thanks. Merging.

@lemire lemire merged commit aeefdf9 into fast-pack:master Feb 28, 2024
@ethlo
Copy link

ethlo commented Feb 28, 2024

Hi again! Thank you for the quick response. I built the latest snapshot and the new code is working, but I was a bit surprised that the encoding would be that much less efficient than the integer encoder for the same input of numbers. I'm unfortunately not well-versed in the integer encoding schemes to know if this is as expected.

Input is 500,000 integer values between 0 and 1,500,000.

IntegratedIntCompressor
269 KB

LongCompressor
2,554 KB

For context, I typically do not need the extended numberspace of longs, but I sometimes must support it. To simplify my code using the LongCompressor would make things easier.

Any input greatly appreciated!

@blacelle blacelle deleted the 64bit_BinaryPacking branch February 29, 2024 05:01
@blacelle
Copy link
Collaborator Author

blacelle commented Feb 29, 2024

IntegratedIntCompressor is dedicated to sorted integers, while LongCompressor manages unsorted longs. There is no IntegratedLongCompressor yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants