Add on_after_logout method to user_manager #1427
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fastapi_users/fastapi_users.py
Outdated
There was a problem hiding this comment.
This was autoformatting done by running the linting command
hatch run lint|
Will this RP be merged? |
|
@heiskane is it possible to release this please? |
Yes its ready to merge. |
|
Hello. Can you merge and release please @heiskane? |
|
Hey. To clarify I'm not a maintainer in this repository so i don't have the ability to merge. Not sure if there is anything else needed of me here as there are no conflicts with this branch. |
|
@frankie567 could you please let us know the current status of this feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to perform custom logic (analytic etc.) after logout for the same reasons as in
on_after_login.I am currently using fast-api for serving html content. I know its not the primary use-case for it but its pretty well supported. Because of this login/logout requests come from html forms instead of api calls from javascript so login/logout routes need to handle http redirects. For login requests its easy to handle with the
on_after_loginmethod on the user_manager but for logouts there is no such option. Currently to add custom redirects to logout requires manually implementing both login and logout routes so having aon_after_logoutmethod would make things much more convenient.