Move keyboard height & padding preferences into theme configuration #765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5b5c5f4 to
3440ac3
Compare
|
Theme preferences are for visual appearance only and should never affect KeyEvent detection. But keyboard height and padding definitely have an impact on KeyEvent detection. |
3440ac3 to
1272167
Compare
I see, thanks for reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull moves
keyboardHeightPercent,keyboardSidePadding, andkeyboardBottomPaddinginto the "Themes" page.While I was tinkering with the settings, I was confused as to why those preferences were split across two different places. I think this will make a lot more sense than the original preferences layout.