00458: test_ssl: Don't stop ThreadedEchoServer on OSError in ConnectionHandler #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onHandler If `read()` in the ConnectionHandler thread raises `OSError` (except `ConnectionError`), the ConnectionHandler shuts down the entire ThreadedEchoServer, preventing further connections. It also does that for `EPROTOTYPE` in `wrap_conn`. Make sure that the context manager *is* used, and remove the `server.stop()` calls from ConnectionHandler. Backported from 3.12+: python#126503 Co-authored-by: Petr Viktorin <encukou@gmail.com>
frenzymadness
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
read()in the ConnectionHandler thread raisesOSError(exceptConnectionError), the ConnectionHandler shuts down the entire ThreadedEchoServer, preventing further connections.It also does that for
EPROTOTYPEinwrap_conn.Make sure that the context manager is used, and remove the
server.stop()calls from ConnectionHandler.Backported from 3.12+:
python#126503