Skip to content

Fix javadoc error caused by having protected parameters public methods #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2020
Merged

Fix javadoc error caused by having protected parameters public methods #470

merged 1 commit into from
Aug 11, 2020

Conversation

lahirumaramba
Copy link
Member

AbstractFirebaseAuth.Builder has public methods setTokenFactory and setUserManager that accepts protected parameters, which cause javadoc errors.

This PR is based on: b413c7a

hiranya911
hiranya911 approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍

@lahirumaramba lahirumaramba merged commit e72bf8a into master Aug 11, 2020
@lahirumaramba lahirumaramba deleted the lm-fix-protected branch August 11, 2020 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@hiranya911 hiranya911 hiranya911 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@lahirumaramba lahirumaramba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lahirumaramba @hiranya911