Skip to content

[FR] Type hint the source code #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
takos22 opened this issue Sep 1, 2021 · 4 comments
Open

[FR] Type hint the source code #569

takos22 opened this issue Sep 1, 2021 · 4 comments
Assignees
@lahirumaramba
Labels
api: core help wanted type: feature request

Comments

@takos22
Copy link

takos22 commented Sep 1, 2021

Is your feature request related to a problem? Please describe.
When developing with this library, I constantly have to type hint variables returned by the functions, so my autocompleter suggests the right properties and for cleaner code.

Describe the solution you'd like
It would be great if you could type hint the library or at least the public API in order to help type checkers, autocompleters and collaboration.

Describe alternatives you've considered
None

Additional context
None
@google-oss-bot
Copy link

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@lahirumaramba lahirumaramba self-assigned this Sep 1, 2021
@lahirumaramba
Copy link
Member

Hi @takos22, Thank you for the feature request!
We agree that this will be a great addition to improve the SDK. While I cannot promise you a timeline at the moment, we will use this github issue to track the progress in the future.

In the meantime, you can also help us speed things up by providing PRs! :)

@Mowinski
Copy link

Do you have any progress on it? I still get infrastructure\push_notifications.py:7: error: Skipping analyzing "firebase_admi n": module is installed, but missing library stubs or py.typed marker error on mypy :(

@heckad
Copy link

heckad commented Aug 17, 2023

@lahirumaramba, maybe you can add py.typed file to the library? This will remove the message from mypy. And then add types.

@heckad heckad mentioned this issue Aug 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lahirumaramba lahirumaramba

Labels
api: core help wanted type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@lahirumaramba @Mowinski @google-oss-bot @heckad @takos22