Skip to content

Add missing return type for firestore.client() #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 20, 2023
Merged

Add missing return type for firestore.client() #747

merged 2 commits into from
Dec 20, 2023

Conversation

wliumelb
Copy link
Contributor

firestore.client() should have return type google.cloud.firestore.Client

wliumelb and others added 2 commits December 16, 2023 01:18
@wliumelb
Add missing return type for firebase_admin.firestore.client()
4627ee9 
firestore.client() should have return type google.cloud.firestore.Client
@lahirumaramba
Merge branch 'master' into master
115a437
lahirumaramba
lahirumaramba approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@lahirumaramba lahirumaramba merged commit 3c39186 into firebase:master Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wliumelb @lahirumaramba