Skip to content

fix(auth): Fixed auth error code parsing #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −1
Open

fix(auth): Fixed auth error code parsing #908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion firebase_admin/_auth_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ def _parse_error_body(response):
separator = code.find(':')
if separator != -1:
custom_message = code[separator + 1:].strip()
code = code[:separator]
code = code[:separator].strip()

return code, custom_message

Expand Down
13 changes: 13 additions & 0 deletions integration/test_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,6 +724,19 @@ def test_email_sign_in_with_settings(new_user_email_unverified, api_key):
assert id_token is not None and len(id_token) > 0
assert auth.get_user(new_user_email_unverified.uid).email_verified

def test_auth_error_parse(new_user_email_unverified):
action_code_settings = auth.ActionCodeSettings(
ACTION_LINK_CONTINUE_URL, handle_code_in_app=True, link_domain="cool.link")
with pytest.raises(auth.InvalidHostingLinkDomainError) as excinfo:
auth.generate_sign_in_with_email_link(new_user_email_unverified.email,
action_code_settings=action_code_settings)
assert str(excinfo.value) == ('The provided hosting link domain is not configured in Firebase '
'Hosting or is not owned by the current project '
'(INVALID_HOSTING_LINK_DOMAIN). The provided hosting link '
'domain is not configured in Firebase Hosting or is not owned '
'by the current project. This cannot be a default hosting domain '
'(web.app or firebaseapp.com).')


@pytest.fixture(scope='module')
def oidc_provider():
Expand Down