Skip to content

Conversation

a-maurice
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Running into permission problems with the token, so changing the logic to use the default token when making the PR. Every other step still uses the previous token though, since that works for the other steps.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

https://github.com/firebase/firebase-cpp-sdk/actions/runs/13643145191


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice requested a review from jonsimantov March 4, 2025 00:58
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Mar 4, 2025
@a-maurice a-maurice merged commit af37b04 into main Mar 4, 2025
21 of 29 checks passed
@a-maurice a-maurice deleted the am-github_token branch March 4, 2025 18:49
@firebase firebase locked and limited conversation to collaborators Apr 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants