feat: make traceContext accessible #1696
Open
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2744d66 to
183ca42
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR makes the internal traceContext accessible by exporting it publicly in both v1 and v2, addressing the linked issue.
- Exposes traceContext in both src/v1/index.ts and src/v2/index.ts
- Removes the @internal annotation from traceContext in src/common/trace.ts
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/v2/index.ts | Exports traceContext to make it publicly accessible |
| src/v1/index.ts | Exports traceContext to ensure consistency with v2 |
| src/common/trace.ts | Removes the internal annotation from traceContext |
Comments suppressed due to low confidence (1)
src/common/trace.ts:2
- The removal of the @internal annotation from traceContext appears intentional to make it publicly available. Ensure that the public API documentation is updated accordingly to reflect the new accessibility of traceContext.
/* @internal */
taeold
reviewed
Jun 3, 2025
Comment on lines
+38
to
+39
| export { traceContext } from "../common/trace"; | ||
|
|
There was a problem hiding this comment.
let's not add any new "feature" in 1st Gen namespace - not technically necessary but more of in the name of principle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1676