Skip to content

Backfill fixes for hybrid docs #9197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 8, 2025
Merged

Backfill fixes for hybrid docs #9197

merged 3 commits into from
Aug 8, 2025

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Aug 7, 2025 •
edited
Loading

Backfill documentation fixes per cl/791925900 (internal).

  • remove <p> tags - these are not generally necessary and cause markdown inside them to not work
  • add a link to console to the RequestOptions description
  • use @remarks to separate extra details of a method from the summary that should go in the table of contents at the top

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 7, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: ae5d8b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 7, 2025 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (e25317f) and merge commit (91cba0e).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/j57FJ1dhSl.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 7, 2025 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (e25317f) and merge commit (91cba0e).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/BdQYRnfCgY.html

@hsubox76 hsubox76 changed the title Ch fix hybrid docs Backfill fixes for hybrid docs Aug 7, 2025
@hsubox76 hsubox76 marked this pull request as ready for review August 8, 2025 18:25
@hsubox76 hsubox76 requested review from a team as code owners August 8, 2025 18:25
@hsubox76 hsubox76 merged commit cc605e7 into main Aug 8, 2025
37 of 38 checks passed
@hsubox76 hsubox76 deleted the ch-fix-hybrid-docs branch August 8, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DellaBitta DellaBitta DellaBitta approved these changes

@rachelsaunders rachelsaunders rachelsaunders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hsubox76 @google-oss-bot @DellaBitta @rachelsaunders