Skip to content

Add secrets for testapps #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2022
Merged

Add secrets for testapps #103

merged 1 commit into from
Jul 8, 2022

Conversation

DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Jul 7, 2022 •
edited
Loading

Add the secrets for the test apps. This one step in many working toward creating CI builds of our testapps for all platforms.

  • This is required to build for Android in our CI. Our Gradle plugin will fail if thegoogle-services.json file associated with a particualr tesapp doesn't exist.
  • Adding the iOS secrets as well in case we want to implement the execution of tests in CI in the future, or use the CI to builds the testapps in the cloud to downoad and run them locally afterwards.

@DellaBitta DellaBitta requested a review from cynthiajoan July 7, 2022 17:41
@DellaBitta DellaBitta marked this pull request as ready for review July 7, 2022 19:16
@DellaBitta DellaBitta merged commit b74606b into main Jul 8, 2022
@DellaBitta DellaBitta deleted the feature/gha_secrets branch July 8, 2022 16:52
@firebase firebase locked and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cynthiajoan cynthiajoan cynthiajoan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DellaBitta @cynthiajoan