Skip to content

Conversation

Grant-Postma
Copy link

No description provided.

Copy link

@alexames alexames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass on the code, I need to look closer at the actual logic of the functions so I might have more feedback later.

using statements moved below
import statemetns.
Comment clarification.
Making a few functions static.
Modifying string parameter to be const&.
Using below import statements.
@alexames alexames merged commit 85cdb87 into firebase:demo-dev Jun 19, 2020
@firebase firebase locked and limited conversation to collaborators Jul 20, 2020
@Grant-Postma Grant-Postma deleted the database-setup branch July 20, 2020 13:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants