-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[FirebaseAI] Bump to v12 #900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @dlarocque, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've updated the ai-react-app
to use Firebase SDK version 12. This upgrade is crucial for enabling new 'grounding' functionalities within the application. The change primarily involves updating the firebase
package and its extensive set of associated sub-packages, which also led to updates in various build-related dependencies to maintain compatibility and leverage the latest tooling.
Highlights
- Firebase SDK Major Version Upgrade: The core change in this pull request is the upgrade of the
firebase
SDK from version11.8.0
to12.0.0
in theai-react-app
project. This is a major version bump, indicating potentially breaking changes or significant new features. - Extensive Firebase Sub-package Updates: This version bump of the main
firebase
package has led to a cascade of updates across almost all@firebase
sub-packages (e.g.,@firebase/ai
,@firebase/analytics
,@firebase/app
,@firebase/auth
,@firebase/firestore
, etc.), ensuring compatibility and leveraging the latest features and fixes within the Firebase ecosystem. Notably,@firebase/ai
received a major version bump from1.3.0
to2.0.0
. - Build Tool Dependency Expansion: The update also necessitated significant changes in the
yarn.lock
file, including the addition of numerous platform-specific binaries for build tools likeesbuild
androllup
. This suggests an expansion of supported build environments or optimizations for cross-platform development within the project's build process.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Firebase SDK to version 12.0.0. This is a major version bump, which, as the description notes, is required for using the new grounding features with Firebase AI. The changes are confined to package.json
and the corresponding yarn.lock
file update, which is expected. The changes look good and are necessary to leverage the latest Firebase AI capabilities.
Required for grounding