Skip to content

Conversation

nicolasgarnier
Copy link
Contributor

@nicolasgarnier nicolasgarnier commented Apr 6, 2018

  • Updated firestore-extend-with-function to SDK v1.0.0
  • Deleted the 2 full samples (full-text-search and presence) since they are also in https://github.com/firebase/functions-samples and we'll prefer linking to there (also https://github.com/firebase/functions-samples is already updated). Eric will change the import tags
  • Re-indented all code the google-style way (2 spaces indent for blocks and 4 spaces indent for line continuation).
  • Removed the indent rule since it's not compatible with Google's style guide.

@nicolasgarnier nicolasgarnier requested a review from samtstern April 6, 2018 18:47
@nicolasgarnier
Copy link
Contributor Author

@samtstern FYI

@nicolasgarnier
Copy link
Contributor Author

@egilmorez FYI

@nicolasgarnier
Copy link
Contributor Author

Will need to re-generate and re-publish the following docs:

@nicolasgarnier
Copy link
Contributor Author

Sam's OOO @AbeHaskins FYI

@nicolasgarnier
Copy link
Contributor Author

@AbeHaskins 's OK. I'll merge, if @samtstern 's unhappy when he's back we can always fix.

@nicolasgarnier nicolasgarnier merged commit e23e50f into master Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant