Skip to content

Begin snippets for JS SDK vNext #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Sep 14, 2020
Merged

Begin snippets for JS SDK vNext #32

merged 23 commits into from
Sep 14, 2020

Conversation

samtstern
Copy link
Contributor

@samtstern samtstern commented Jul 24, 2020 •
edited
Loading

Products:

  • Auth
  • Database
  • FirebaseApp
  • Firestore
  • Functions

Housekeeping:

  • Move functions snippets back to where they came from
  • Make vNext snippets live side-by-side with regular snippets
  • Create a script to separate vNext snippets into files
  • Add a check to make sure ^ script has been run each time
  • Add support for the snippet registry to ignore whole files (external work)

@samtstern samtstern requested a review from egilmorez July 24, 2020 14:29
@samtstern samtstern changed the title [WIP] Functions snippets vNext [WIP] Firestore and Functions snippets vNext Sep 2, 2020
@samtstern samtstern changed the title [WIP] Firestore and Functions snippets vNext [WIP] Snippets for JS SDK vNext Sep 3, 2020
@samtstern samtstern marked this pull request as ready for review September 14, 2020 12:56
@samtstern samtstern changed the title [WIP] Snippets for JS SDK vNext Begin snippets for JS SDK vNext Sep 14, 2020
@samtstern samtstern merged commit 0fffbaf into master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samtstern