Skip to content

fix broken ref docs urls #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 22, 2023
Merged

fix broken ref docs urls #343

merged 3 commits into from
May 22, 2023

Conversation

thatfiredev
Copy link
Member

Closes #341

This PR should:

  • Fix broken v8 ref doc urls:
    • js/firebase.User --> js/v8/firebase.User
    • js/firebase.firestore.GetOptions --> js/v8/firebase.firestore.GetOptions
  • Update the separate-snippets.ts script to properly map v8 urls to v9 when generating the modular snippets.

@thatfiredev thatfiredev requested a review from jhuleatt May 22, 2023 11:43
jhuleatt
jhuleatt approved these changes May 22, 2023
View reviewed changes
Copy link
Collaborator

@jhuleatt jhuleatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thatfiredev!

@thatfiredev thatfiredev merged commit 2414b55 into master May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhuleatt jhuleatt jhuleatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Oudated link for user object properties
2 participants
@thatfiredev @jhuleatt