Skip to content

gregfenton patch issue 221 #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 22, 2023
Merged

gregfenton patch issue 221 #344

merged 3 commits into from
May 22, 2023

Conversation

gregfenton
Copy link
Contributor

@gregfenton gregfenton commented May 22, 2023 •
edited
Loading

@gregfenton gregfenton mentioned this pull request May 22, 2023
Closed
@thatfiredev
Copy link
Member

Seems like that function is also called here:

snippets-web/firestore/test.solution-counters.js

Line 70 in c356483

return incrementCounter(db, ref, 10);

and here:

snippets-web/firestore/test.solution-counters.js

Line 78 in c356483

return incrementCounter(db, ref, 10);

We'll need to remove the db argument in these places too.

@gregfenton
Update test.solution-counters.js
dcf749a 
remove unused parameter from example calls to the function
thatfiredev
thatfiredev approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@thatfiredev thatfiredev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gregfenton !

@thatfiredev thatfiredev merged commit 8fc7be2 into firebase:master May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatfiredev thatfiredev thatfiredev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregfenton @thatfiredev