use app.json_encoder #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@winstonf88 I like the idea behind this change. The test failure seem legitimate. Does this line need to be wrapped in an application context? Or is there some other way to pass in the current application? |
|
I added the app context inside tests, I believe there is no other way. @jacebrowning |
jacebrowning
reviewed
Oct 5, 2017
| date = datetime(2017, 10, 5, 15, 22) | ||
| with app.app_context(): | ||
| content = renderer.render(date, MediaType('application/json')) | ||
| self.assertEqual(content, '"{}"'.format(date.isoformat())) |
jacebrowning
approved these changes
Oct 5, 2017
|
Release in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flask-api JSONRenderer class is ignoring custom JsonEncoder and directly using the default class provided by flask, it should use the applications
json_encoderatribute.Example:
http://flask.pocoo.org/snippets/119/