Skip to content

fixes https://github.com/flask-api/flask-api/issues/86 #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2017
Merged

fixes https://github.com/flask-api/flask-api/issues/86 #87

merged 1 commit into from
Dec 2, 2017

Conversation

lamehost
Copy link
Contributor

@lamehost lamehost commented Dec 2, 2017

No description provided.

Copy link
Member

@jacebrowning jacebrowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jacebrowning jacebrowning merged commit 376815d into flask-api:develop Dec 2, 2017
@burkestar
Copy link

With this change, we started seeing OutOfMemory issues on the server. It seems that for large file uploads this would allocate a massive buffer in memory (only in cases where the content type isn't specified?). The buffer should only need to be a portion of the overall content length since it parses in chunks at a time.

When patching to restore the old behavior (let Werkzeug set the default buffer size) then it resolves the memory issue and we don't experience issues with parsing really large requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants