Skip to content

lib: zstd: only require a C compiler #10316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

lib: zstd: only require a C compiler #10316

wants to merge 1 commit into from

Conversation

ThomasDevoogdt
Copy link
Contributor

@ThomasDevoogdt ThomasDevoogdt commented May 8, 2025 •
edited
Loading

@ThomasDevoogdt ThomasDevoogdt force-pushed the bugfix/lib-zstd-only-require-a-c-compiler branch from a1b4202 to 1a33abe Compare May 8, 2025 17:57
@cosmo0920 cosmo0920 added this to the Fluent Bit v4.0.2 milestone May 9, 2025
@edsiper
Copy link
Member

edsiper commented May 9, 2025

(cc: @cosmo0920) the changes should not touch the bundled dependencies because when we upgrade those changes will be lost. I recommend trying to merge the changes in libzstd repo first

@ThomasDevoogdt
Copy link
Contributor Author

@edsiper The changes are already upstream. See the git commit message.

This was referenced May 16, 2025
Open
Open
@ThomasDevoogdt
Copy link
Contributor Author

@edsiper @cosmo0920 this has been approved (and upstreamed) for quite some time, can this be merged?

@ThomasDevoogdt
lib: zstd: only require a C compiler
2cc0058 
Upstream: facebook/zstd@769723a
Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
@ThomasDevoogdt ThomasDevoogdt force-pushed the bugfix/lib-zstd-only-require-a-c-compiler branch from 1a33abe to 2cc0058 Compare July 14, 2025 20:59
@ThomasDevoogdt
Copy link
Contributor Author

@cosmo0920 @edsiper It's again a bit silent around this PR. Everything is approved and ready to be merged, on what do we exactly wait? Can you just merge this one?

@ThomasDevoogdt
Copy link
Contributor Author

@cosmo0920 Can you merge this one? Or add milestone that might land anytime soon. I have the feeling that next means forgotten.

@cosmo0920
Copy link
Contributor

cosmo0920 commented Aug 8, 2025 •
edited
Loading

We don't want to merge this PR without merging for upstream libzstd library itself.

@cosmo0920
Copy link
Contributor

This commit facebook/zstd@769723a is not released as a stable version officially, so we need to wait for merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmo0920 cosmo0920 cosmo0920 approved these changes

@edsiper edsiper Awaiting requested review from edsiper edsiper is a code owner

@leonardo-albertovich leonardo-albertovich Awaiting requested review from leonardo-albertovich

@fujimotos fujimotos Awaiting requested review from fujimotos fujimotos is a code owner

@koleini koleini Awaiting requested review from koleini koleini is a code owner

Assignees
No one assigned
Labels
docs-required
Projects
None yet
Milestone
Fluent Bit Next
Development

Successfully merging this pull request may close these issues.
3 participants
@ThomasDevoogdt @edsiper @cosmo0920