Almost complete rewrite of async sender and async handler #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

repeatedly merged 1 commit into fluent:master from arcivanov:issue_105

Dec 9, 2017

Member

arcivanov commented Dec 7, 2017

No description provided.

arcivanov force-pushed the issue_105 branch from b8216fc to 8012768 Compare

December 7, 2017 10:01

arcivanov changed the title ~~Issue 105~~ Almost complete rewrite of async sender and async handler

coveralls commented Dec 7, 2017 •

edited

Loading

Coverage decreased (-4.6%) to 88.217% when pulling b8216fc on arcivanov:issue_105 into f357a2d on fluent:master.

Member Author

arcivanov commented Dec 7, 2017

@repeatedly @panta

arcivanov force-pushed the issue_105 branch from 8012768 to c42c480 Compare

December 7, 2017 10:10

coveralls commented Dec 7, 2017 •

edited

Loading

Coverage decreased (-4.6%) to 88.217% when pulling c42c480 on arcivanov:issue_105 into f357a2d on fluent:master.

arcivanov force-pushed the issue_105 branch from c42c480 to aeb84fd Compare

December 7, 2017 10:23

coveralls commented Dec 7, 2017 •

edited

Loading

Coverage decreased (-4.5%) to 88.254% when pulling aeb84fd on arcivanov:issue_105 into f357a2d on fluent:master.

arcivanov force-pushed the issue_105 branch from aeb84fd to 6f162c4 Compare

December 7, 2017 11:14

coveralls commented Dec 7, 2017

Coverage decreased (-3.9%) to 88.889% when pulling 6f162c4 on arcivanov:issue_105 into f357a2d on fluent:master.

1 similar comment

coveralls commented Dec 7, 2017 •

edited

Loading

Coverage decreased (-3.9%) to 88.889% when pulling 6f162c4 on arcivanov:issue_105 into f357a2d on fluent:master.

arcivanov force-pushed the issue_105 branch from 6f162c4 to a72b49f Compare

December 8, 2017 01:44

coveralls commented Dec 8, 2017 •

edited

Loading

Coverage decreased (-2.3%) to 90.476% when pulling a72b49f on arcivanov:issue_105 into f357a2d on fluent:master.

2 similar comments

coveralls commented Dec 8, 2017

Coverage decreased (-2.3%) to 90.476% when pulling a72b49f on arcivanov:issue_105 into f357a2d on fluent:master.

coveralls commented Dec 8, 2017

Coverage decreased (-2.3%) to 90.476% when pulling a72b49f on arcivanov:issue_105 into f357a2d on fluent:master.

arcivanov force-pushed the issue_105 branch 2 times, most recently from c6ae575 to 5f3b462 Compare

December 8, 2017 02:11

coveralls commented Dec 8, 2017 •

edited

Loading

Coverage decreased (-1.7%) to 91.054% when pulling 5f3b462 on arcivanov:issue_105 into f357a2d on fluent:master.

2 similar comments

coveralls commented Dec 8, 2017

Coverage decreased (-1.7%) to 91.054% when pulling 5f3b462 on arcivanov:issue_105 into f357a2d on fluent:master.

coveralls commented Dec 8, 2017

Coverage decreased (-1.7%) to 91.054% when pulling 5f3b462 on arcivanov:issue_105 into f357a2d on fluent:master.

coveralls commented Dec 8, 2017

Coverage decreased (-1.7%) to 91.054% when pulling 5f3b462 on arcivanov:issue_105 into f357a2d on fluent:master.

1 similar comment

coveralls commented Dec 8, 2017 •

edited

Loading

Coverage decreased (-1.7%) to 91.054% when pulling 5f3b462 on arcivanov:issue_105 into f357a2d on fluent:master.

arcivanov force-pushed the issue_105 branch 2 times, most recently from 2b1dab4 to 65e05b9 Compare

December 8, 2017 02:17

coveralls commented Dec 8, 2017 •

edited

Loading

Coverage decreased (-1.7%) to 91.054% when pulling 2b1dab4 on arcivanov:issue_105 into f357a2d on fluent:master.

2 similar comments

coveralls commented Dec 8, 2017

Coverage decreased (-1.7%) to 91.054% when pulling 2b1dab4 on arcivanov:issue_105 into f357a2d on fluent:master.

coveralls commented Dec 8, 2017

Coverage decreased (-1.7%) to 91.054% when pulling 2b1dab4 on arcivanov:issue_105 into f357a2d on fluent:master.

coveralls commented Dec 8, 2017 •

edited

Loading

Coverage decreased (-1.5%) to 91.318% when pulling 65e05b9 on arcivanov:issue_105 into f357a2d on fluent:master.

2 similar comments

coveralls commented Dec 8, 2017

Coverage decreased (-1.5%) to 91.318% when pulling 65e05b9 on arcivanov:issue_105 into f357a2d on fluent:master.

coveralls commented Dec 8, 2017

Coverage decreased (-1.5%) to 91.318% when pulling 65e05b9 on arcivanov:issue_105 into f357a2d on fluent:master.

arcivanov force-pushed the issue_105 branch from 65e05b9 to 472ab00 Compare

December 8, 2017 05:32

coveralls commented Dec 8, 2017 •

edited

Loading

Coverage increased (+6.6%) to 99.373% when pulling 472ab00 on arcivanov:issue_105 into f357a2d on fluent:master.


          Almost complete rewrite of async sender and async handler

fad318b

Queue timeout removed as it served no purpose other than hide multiple threading issues
asctime format was non-functional
Many tests would silently fail and appear successful
Tests now are near-instantaneous due to removal of sleep

fixes fluent#105, fixes fluent#106

arcivanov force-pushed the issue_105 branch from 472ab00 to fad318b Compare

December 8, 2017 05:41

coveralls commented Dec 8, 2017 •

edited

Loading

Coverage increased (+7.2%) to 100.0% when pulling fad318b on arcivanov:issue_105 into f357a2d on fluent:master.

Member Author

arcivanov commented Dec 8, 2017

@repeatedly @panta please review and comment

Member Author

arcivanov commented Dec 9, 2017

@repeatedly bump

repeatedly merged commit b7254b9 into fluent:master

Member

repeatedly commented Dec 9, 2017

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet